+ Start a Discussion
Ashley BrinkmeyerAshley Brinkmeyer 

Having trouble with 2nd unit challenge in Apex Testing module

Hi everyone! I read through the unit about testing Apex triggers and feel like I had a pretty good understanding, but the code I wrote for the challenge test isnt running like I thought it would. Here is what I have:

@isTest
private class TestRestrictContactByName {

    @isTest static void metodoTest() 
    {
    
        
        
        Contact c = new Contact(FirstName='James', LastName = 'INVALIDNAME',email='Test@test.com');
        

        
        // Perform test
        Test.startTest();
        Database.SaveResult result = Database.insert(c);
        Test.stopTest();
        

        System.assert(!result.isSuccess());
        System.assert(result.getErrors().size() > 0);
        System.assertEquals('The Last Name "INVALIDNAME" is not allowed for DML',
                             result.getErrors()[0].getMessage());


        
    }
    
}
and this is the error I get when I run it:

"System.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, The Last Name "INVALIDNAME" is not allowed for DML: []"

To me, it seems like it's throwing an error because the trigger is firing and not allowing an insert, but I don't understand why it would do that when I'm trying to test to make sure it DOES get thrown. I know I'm missing something here and I'd really appreciate some insight. Thank you!
Ajay Nagar 7Ajay Nagar 7
Try this code :

try {
       Database.SaveResult result = Database.insert(c);
} catch (DMLException e) {
      System.assert(e.getMessage().contains('The Last Name INVALIDNAME is not allowed for DML'), 'message=' + e.getMessage());
}
Amit Chaudhary 8Amit Chaudhary 8
Hi Ashley Brinkmeyer,

https://developer.salesforce.com/forums/?id=906F0000000BNjqIAG
Please try below code:-
@isTest
private class TestRestrictContactByName {

    static testMethod void  metodoTest() 
    {
    
        List<Contact> listContact= new List<Contact>();
        Contact c1 = new Contact(FirstName='Francesco', LastName='Riggio' , email='Test@test.com');
        Contact c2 = new Contact(FirstName='Francesco1', LastName = 'INVALIDNAME',email='Test@test.com');
        listContact.add(c1);
        listContact.add(c2);

        Test.startTest();
            try
            {
                insert listContact;
            }
            catch(Exception ee)
            {
            }
        Test.stopTest(); 
    }
}

Note:- Before submitting the challenge you need to run your test class and need to check code coverage on trigger like below
To Run Test class please check on below button


Yon can also try below code. I hope that will help u also.
@isTest
private class TestRestrictContactByName 
{
    @isTest static void metodoTest() 
    {
        Contact c = new Contact(FirstName='James', LastName = 'INVALIDNAME',email='Test@test.com');
        Test.startTest();
			try {
				   Database.SaveResult result = Database.insert(c);
			} catch (DMLException e) {
				  System.assert(e.getMessage().contains('The Last Name INVALIDNAME is not allowed for DML'), 'message=' + e.getMessage());
			}
        Test.stopTest();
    }
}
NOTE:- for Error msg you need to add try and catch.
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
Ashley BrinkmeyerAshley Brinkmeyer

Thanks for your time. I got it to work using the following code:

 

@isTest
private class TestRestrictContactByName {

    @isTest static void metodoTest() 
    {
        Contact c = new Contact(LastName = 'INVALIDNAME');
  
       
        Database.SaveResult result = Database.insert(c, false);
      
       
        System.assert(!result.isSuccess());
        System.assert(result.getErrors().size() > 0);
        System.assertEquals('The Last Name "INVALIDNAME" is not allowed for DML',
                             result.getErrors()[0].getMessage());


        
    }
    
}