+ Start a Discussion
Rakesh SRakesh S 

How to Bulkify trigger Code

Hi All,

i want to create an opportunity with description and account field are mandatory. the selected account's contacts object field(Description) need to be update.
Ex. Creating opportunity like JPJN and selected account IBM and Description like JPJN is fortune company.
now we need to retrieve all IBM contacts and then in every contact Description field is there. We need to update that description field value as Description filed value of JPJN(means JPJN is fortune company).

i was tried code and it works successfully. but not Bulkify code.
Please suggest or write code with bulkifying.

trigger DesUpdate on Opportunity (after insert) {
List<Contacts> con = new List<contacts>();
if(trigger.isafter){
        for(opportunity opp : trigger.new){
            if(opp.AccountId != null){
              contact c = [select id,name,accountid,Description from contact where accountid =: opp.AccountId];
              c.Description = opp.Description;
              update c;
            }
        }
        update con;
    }
}
 

Thank you.
 

Amit Chaudhary 8Amit Chaudhary 8
Please try below code.
trigger DesUpdate on Opportunity (after insert) 
{
	if(trigger.isafter)
	{
		Set<ID> setAccId = new Set<ID>();
		
        for(opportunity opp : trigger.new)
		{
            if(opp.AccountId != null)
			{
				setAccId.add(opp.AccountId);
			}
		}	

		if(setAccId.size() > 0 )
		{
			List<Contacts> listContactToUpdate = new List<contacts>();
			List<Contact> lstContact = [ select id,name,accountid,Description from contact where accountid =: setAccId ] ;
			Map<Id,List<Contact>> mapAccountWiseContact = new Map<Id,List<Contact>>();
			for( Contact cont : lstContact )
			{
				if(mapAccountWiseContact.contaisKey(cont.accountid))
				{
					List<Contact> lstCont = mapAccountWiseContact.get(cont.accountid);
					lstCont.add(cont);
				}
				else
				{
					List<Contact> lstCont = new List<Contact>();
					lstCont.add(cont);
					mapAccountWiseContact.put(cont.accountid,lstCont);
				}
			}
		
			for(opportunity opp : trigger.new)
			{
				if(opp.AccountId != null && mapAccountWiseContact.containsKey(opp.AccountId) )
				{
					List<Contact> lstContacts = mapAccountWiseContact.get(opp.AccountId);
					for(Contact cont : lstContacts)
					{
						cont.Description = opp.Description;
						listContactToUpdate.add(cont);
					}
				}
			}
			if(listContactToUpdate.size() >0 )
			{
				update listContactToUpdate;
			}	
		}	
    }
}
http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org. 

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers


4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Thanks
Amit Chaudhary
 
Dinesh Voonna 17Dinesh Voonna 17
Hi Amit,
I have a doubt in bulkifing the code for after insert.

Let me explain the sceanrio.
Informatica is uploading opportunities records around 250 in sfdc. After inserting the opportunities, I need to update with some values to all the records. So I have written below logic to do this activity. I haven't written any future method to do this activity. Is the below code bulkified or not?
Will my logic work for bulk records?
 
if((Trigger.isInsert && Trigger.isAfter) || (Trigger.isUpdate && Trigger.isAfter)){
        Digital_ProposalAutomation dpa = new Digital_ProposalAutomation();
     Id prepipelineRecordId = Schema.SObjectType.Opportunity.getRecordTypeInfosByName().get('Pre-Pipeline Opportunity').getRecordTypeId();
     Id pipelineRecordId = Schema.SObjectType.Opportunity.getRecordTypeInfosByName().get('Pipeline Opportunity').getRecordTypeId();  
        for(Opportunity opp : Trigger.new){
          if(opp.isDigitalSpearHead__c == TRUE && opp.RecordTypeId == prepipelineRecordId && opp.Status__c == 'Unworked' && opp.StageName == '1%'){
             dpa.OpportunityUpdation(opp);
          }
        
          if(opp.isDigitalSpearHead__c == TRUE && opp.RecordTypeId == pipelineRecordId){
             Id accId = opp.AccountId;
             dpa.ProposalCreation(opp, accId);
          }
        }
    }

Regrds,
Dinesh