+ Start a Discussion
Mike DeMilleMike DeMille 

I need help bulkifying this trigger

This is a simple field update trigger and I need help getting it bulkified.  I appreciate any help.

trigger Update_MQL on Lead (before insert, before update) {
for (Lead myLead : Trigger.new)
{
    if (myLead.MQL_Date__c == null && (myLead.Status =='MQL (Marketing Qualified Lead)' || myLead.Status == 'SAL (Sales Accepted Lead)'))
    {myLead.MQL_Date__c = system.today();
    }else { myLead.MQL_Date__c = myLead.MQL_Date__c;
    }
     }
     
}
Best Answer chosen by Mike DeMille
Amit Chaudhary 8Amit Chaudhary 8
Hi Mike DeMille ,

Your trigger is perfect and bulkify.

if you want to do small change then try below code
trigger Update_MQL on Lead (before insert, before update) 
{
	for (Lead myLead : Trigger.new)
	{
		if (myLead.MQL_Date__c == null && (myLead.Status =='MQL (Marketing Qualified Lead)' || myLead.Status == 'SAL (Sales Accepted Lead)'))
		{
			myLead.MQL_Date__c = system.today();
		}
        /* No need to else as you are assigning same field value
        else 
		{ 
			myLead.MQL_Date__c = myLead.MQL_Date__c;
		}
        */
	}
     
}

Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

 

All Answers

LBKLBK
Hi Mike,

Your trigger as it is can handle bulk inserts and updates without any issues.

You don't have to bulkify it any further, unless there is more lines of code to be added.
Shiva RajendranShiva Rajendran
Hi MIke ,
Yeah this code will work perfectly :)
By the way , bulkify come's into picture when doing DML operation.
eg : Instead of the below code
for(integer i=0;i<200;i++)
 {
   Account acc=new Account(name="myName");
 insert acc;
}

Always bulkify the code and do the dml operation like the code below
List<Account> accounts=new List<Account>();
for(integer i=0;i<200;i++)
{
   account acc=new Account(name="myName");
 accounts.add(acc);
}
insert accounts;

Thanks and Regards,
Shiva RV




 
Amit Chaudhary 8Amit Chaudhary 8
Hi Mike DeMille ,

Your trigger is perfect and bulkify.

if you want to do small change then try below code
trigger Update_MQL on Lead (before insert, before update) 
{
	for (Lead myLead : Trigger.new)
	{
		if (myLead.MQL_Date__c == null && (myLead.Status =='MQL (Marketing Qualified Lead)' || myLead.Status == 'SAL (Sales Accepted Lead)'))
		{
			myLead.MQL_Date__c = system.today();
		}
        /* No need to else as you are assigning same field value
        else 
		{ 
			myLead.MQL_Date__c = myLead.MQL_Date__c;
		}
        */
	}
     
}

Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

 
This was selected as the best answer
Mike DeMilleMike DeMille
Thank you very much for the help all of you.