Example Responses to False Positives in a Security Review Failure Report

The following example shows how to document your responses to false positives listed in a Salesforce security review failure report. It’s written to support a retest submission.

Reported VulnerabilityLocationResponse
Insecure Software VersionjQueriesUpdated.
Insecure Software Versionmoment.jsNo user input flows into moment parsing. User input flows only to Salesforce Date fields.
Insecure Storage of Sensitive DataUserConfig_c.objectThe apiKey__c field is encrypted before setting with the encryption key, which is stored in a protected custom setting.
Insecure Storage of Sensitive DataIssueInvite_c.objectThe password__c field is a support-agent selected password to share resources publicly with the internet. It’s not a user-owned secret.
Insecure Storage of Sensitive DataAPIManagement_c.objectWe deprecated this custom setting, but it’s impossible to delete custom setting definitions from managed packages.
Insecure Storage of Sensitive DataAuthManager.clsThe credentials in comments are only example credentials. They do not authenticate to any development or production system.
Stored XSShttps://content.saslesforce.partner.comWe spoke to Jane Doe at Salesforce during office hours on Feb. 1, 2020. This URL is linked to a nonsensitive content domain. The URL has no session data to access back-end information. We were told that this finding could be a false positive.